Helm: Support https for serviceAccounts and InternalTrafficPolicy for services. #6383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpaschalis
reviewed
Feb 19, 2024
Comment on lines
255
to
263
| relabelings: [] | ||
| # - sourceLabels: [__meta_kubernetes_pod_node_name] | ||
| # separator: ; | ||
| # regex: ^(.*)$ | ||
| # targetLabel: nodename | ||
| # replacement: $1 | ||
| # action: replace | ||
| relabelings: [] |
There was a problem hiding this comment.
nit: can we move the example below the relabelings so that it doesn't get rendered weirdly on the README?
tpaschalis
reviewed
Feb 19, 2024
| @@ -10,6 +10,14 @@ internal API changes are not present. | |||
| Unreleased | |||
| ---------- | |||
|
|
|||
| 0.33.0 (2024-02-16) | |||
There was a problem hiding this comment.
nit: let's mention this on the commit message or split the version bump in a different commit so it's easier to keep track of when it came out?
tpaschalis
approved these changes
Feb 19, 2024
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist