agent-static-mixin: include custom 'all' value #6589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpaschalis
force-pushed
the
fix-static-mixin-all-selector
branch
from
899f2ef
to
88c0327
Compare
pracucci
approved these changes
Mar 4, 2024
| @@ -286,6 +286,7 @@ local template = grafana.template; | |||
| value: '$__all', | |||
| }, | |||
| includeAll=true, | |||
| allValues='.*', | |||
There was a problem hiding this comment.
I know I suggested you .* but .+ may actually be slightly more accurate. That's also what jsonnet-libs does by default.
There was a problem hiding this comment.
Yeah, let's change it. I had both addMultiTemplate and addMultiTemplateWithAll helpers with a different default, changing it now.
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
tpaschalis
force-pushed
the
fix-static-mixin-all-selector
branch
from
88c0327
to
4c04185
Compare
rfratto
approved these changes
Mar 4, 2024
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
pracucci
approved these changes
Mar 4, 2024
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it for easier querying on the backend of your choice. I've verified by comparing the resulting dashboards in main and the fix branch
I'm adding the new parameter on the existing helper instead of refactoring to use
addMultiTemplateWithAll, should be enough for now.