Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a broken Windows test #6985

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix a broken Windows test #6985

merged 1 commit into from
Jul 18, 2024

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Jul 18, 2024

This PR escapes characters in Prometheus label values. A test has been failing on the main branch due to it:

--- FAIL: TestLogs (5.08s)
    logs_test.go:130: 
        	Error Trace:	C:/drone/src/static/logs/logs_test.go:130
        	Error:      	Received unexpected error:
        	            	converting reader to metric families failed: text format parsing error in line 4: invalid escape sequence '\U'
        	Test:       	TestLogs

@ptodev ptodev requested a review from wildum July 18, 2024 08:55
@ptodev ptodev merged commit bb5889f into main Jul 18, 2024
10 checks passed
@ptodev ptodev deleted the ptodev/fix-testlogs-win-test branch July 18, 2024 09:19
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Aug 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wildum wildum wildum approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptodev @wildum