Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate HOSTNAME env var #778

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Remove duplicate HOSTNAME env var #778

merged 1 commit into from
Jul 23, 2021

Conversation

hjet
Copy link
Contributor

@hjet hjet commented Jul 23, 2021 •
edited
Loading

PR Description

Cleans up small bug from #772 where HOSTNAME is set twice

@hjet hjet requested review from rfratto and mattdurham July 23, 2021 19:26
mattdurham
mattdurham approved these changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mattdurham mattdurham merged commit 9ad2a18 into main Jul 23, 2021
@mattdurham mattdurham deleted the remove_dup_var branch July 23, 2021 19:57
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
Closed
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
@hjet
Remove duplicate HOSTNAME env var (#778)
de3c7d7
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattdurham mattdurham mattdurham approved these changes

@rfratto rfratto Awaiting requested review from rfratto

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjet @mattdurham