add support for TLSConfig in webhook receiver #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Sep 19, 2024
fayzal-g
reviewed
Sep 20, 2024
| @@ -111,13 +112,21 @@ func (wn *Notifier) Notify(ctx context.Context, as ...*types.Alert) (bool, error | |||
| return false, tmplErr | |||
| } | |||
|
|
|||
| var tlsConfig *tls.Config | |||
| if wn.settings.TLSConfig != nil { | |||
| if tlsConfig, err = wn.settings.TLSConfig.ToCryptoTLSConfig(); err != nil { | |||
There was a problem hiding this comment.
Slightly unrelated to this PR, but we are pretty much redefining the library here: https://github.com/grafana/dskit/blob/main/crypto/tls/tls.go#L87
It would need to be updated to take the certs/keys as a string though (currently only takes filepaths)
There was a problem hiding this comment.
yeah, that's a good point. You'd mention that library but I just went with the same setup that we had for mqtt and forgot about it.
The dskit is more complete also. I could adapt both to use that instead or create another issue to standardize it after this is merged - wdyt?
| }, | ||
| }, | ||
| expMsgError: fmt.Errorf("Unable to use the provided CA certificate"), | ||
| }, |
There was a problem hiding this comment.
Can we add another test case for InsecureSkipVerify: true?
![nightfall-for-github[bot]](https://avatars.githubusercontent.com/in/93044?s=60&v=4){kind=small}
titolins
force-pushed
the
titolins/support_tls_config_for_webhook_receiver
branch
from
caa9015
to
e29973e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TLS configuration support for webhook receivers
Related PR's