Query Label Names and Values from blocks store (#3520)

* Query Label Names from blocks store Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Query Label Values from block store Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Address feedback and unit tests for label names Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add unit test for LabelValues Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Address feedback Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
grafana · Sep 1, 2021 · 0c7c2eb · 0c7c2eb
1 parent 70e0bde
commit 0c7c2eb
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pkg/distributor/distributor.go b/pkg/distributor/distributor.go
@@ -672,6 +672,10 @@ func (d *Distributor) LabelValuesForLabelName(ctx context.Context, from, to mode
 	for v := range valueSet {
 		values = append(values, v)
 	}
+
+	// We need the values returned to be sorted.
+	sort.Strings(values)
+
 	return values, nil
 }
 
@@ -704,9 +708,8 @@ func (d *Distributor) LabelNames(ctx context.Context, from, to model.Time) ([]st
 	for v := range valueSet {
 		values = append(values, v)
 	}
-	sort.Slice(values, func(i, j int) bool {
-		return values[i] < values[j]
-	})
+
+	sort.Strings(values)
 
 	return values, nil
 }