Remove github.com/prometheus/prometheus dependency #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
krajorama
approved these changes
Dec 14, 2022
56quarters
reviewed
Dec 14, 2022
| @@ -159,3 +158,35 @@ func (g *blockingGate) Done() { | |||
| panic("gate.Done: more operations done than started") | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Why was this introduced? This does exactly the same thing as the existing blocking gate
bboreham
pushed a commit
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel Ángel Ortuño ortuman@gmail.com
After merging #239 we introduced a github.com/prometheus/prometheus dependency.
@ go.mod 👉 https://github.com/grafana/dskit/blob/main/go.mod#L28
Apart from being an old version, this is also causing some issues when validating CI in enterprise repositories.
The purpose of this PR is to get rid of it.