Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trivial "util" exported package #247

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented Jan 3, 2023

What this PR does:

Replaced with an internal-only function. This package was never meant to be exported but the change got lost as part of code review.

Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com

Which issue(s) this PR fixes:

See #239

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

This package was never meant to be exported but the change got lost
as part of [code review](#239 (comment)).

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters marked this pull request as ready for review January 3, 2023 19:01
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we may be able to replace our slices.Contains with the implementation in golang.org/x/exp/slices instead.

internal/slices/slices.go Show resolved Hide resolved
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection 😉

@56quarters 56quarters merged commit b2b40c4 into main Jan 4, 2023
@56quarters 56quarters deleted the 56quarters/no-utils branch January 4, 2023 14:07
charleskorn pushed a commit that referenced this pull request Aug 3, 2023
…-exemplars

Revert "Add user and org labels to observed exemplars"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants