Fix typo in gRPC client flag name. #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
approved these changes
Jun 7, 2023
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Jun 8, 2023
pracucci
added a commit
to grafana/mimir
that referenced
this pull request
Jun 8, 2023
* Update dskit to include changes up to and including grafana/dskit#312. * Update docs. * Update glog goroutine permitted to leak in tests. * Update to latest dskit version. * Add changelog entry. * Continue using previous DoUntilQuorum behaviour. * Update dskit to include grafana/dskit#314 * Remove unnecessary parameters. * Update docs. * Fix breaking changes in tests. * Fix linting warning. --------- Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR fixes a typo introduced in #312.
Which issue(s) this PR fixes:
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]