-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instrumented gate: observe permitted and non-permitted queries separately #512
instrumented gate: observe permitted and non-permitted queries separately #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would just add a CHANGELOG entry. Thanks!
…tely This distinction helps when debugging increased congestion on a gate.
6e1d78e
to
bdcced0
Compare
thanks for the review. I added further separation of outcomes between context cancelled and deadline exceeded (and now "other"). Also added a changelog entry. I rebase the branch, so you can look at only the last 2 commits if you want partial diff. |
i also mistakenly committed some other changes; cleared them out in another 2 commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
This distinction helps when debugging increased congestion on a gate.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]