This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Alerting: Add Option to get all alert rules #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Co-authored-by: fkhe <Falk.Haendler@t-systems.com>
|
Hi, @julienduchesne I signed the cla, so the review could start, I guess? Greetings |
|
@PhilipPenquitt I think the PR needs to be rebased first. I would highly appreciate to have this merged soon 😃 |
It's easier to manage folders with UIDs than IDs. This will be used to add that functionality to the Terraform provider
* ListSLOs functionality retrives all SLOs * CreateSLO and GetSLO Functionality implemented * DeleteSLO Functionality implemented * UpdateSLO Functionality implemented * UpdateSLO Functionality corrected * Update Linting Errors * Removes Unnecessary Comments * Update Variable Naming * Lint Checker * Update Tests for SLOs * Updating Slo Types with a comment to original source files * Updated SLO Types and Tests
|
I think the PR should now be ready. @julienduchesne or @alexweav would you be so kind to review this PR. I'd really appreciate that. Thanks in advance! |
|
Hey @m-rcl, |
|
hey @gouthamve , a few weeks ago I spoke to you about this PR at the Meetup in Berlin. Would you be so nice and look into this PR? Thanks in advance |
|
It would be awesome to revive this PR, as Unified Alerts have these new API endpoints. |
JanSF
added a commit
to JanSF/grafana-api-golang-client
that referenced
this pull request
Sep 19, 2023
Squashed commit of the following: commit b384168 Merge: bc342a8 3f84a92 Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Tue May 9 08:44:32 2023 +0200 Merge branch 'grafana:master' into master commit bc342a8 Author: Philip Penquitt <30809710+PhilipPenquitt@users.noreply.github.com> Date: Thu Apr 6 16:49:11 2023 +0200 Trigger Build commit 2a88c53 Author: phpe <30809710+PhilipPenquitt@users.noreply.github.com> Date: Thu Apr 6 16:46:06 2023 +0200 Trigger Build commit 2471267 Author: Elaine Vuong <elaine.yt.vuong@gmail.com> Date: Thu May 4 14:57:04 2023 -0400 SLO: CRUD API Functionality (grafana#145) * ListSLOs functionality retrives all SLOs * CreateSLO and GetSLO Functionality implemented * DeleteSLO Functionality implemented * UpdateSLO Functionality implemented * UpdateSLO Functionality corrected * Update Linting Errors * Removes Unnecessary Comments * Update Variable Naming * Lint Checker * Update Tests for SLOs * Updating Slo Types with a comment to original source files * Updated SLO Types and Tests commit 836a3db Author: Julien Duchesne <julien.duchesne@grafana.com> Date: Thu Apr 27 09:15:11 2023 -0400 Folder UID: Wrong field type (grafana#148) Doh! commit ca95730 Author: Julien Duchesne <julien.duchesne@grafana.com> Date: Thu Apr 27 08:35:50 2023 -0400 Dashboard: Get folder UID from reads (grafana#147) It's easier to manage folders with UIDs than IDs. This will be used to add that functionality to the Terraform provider commit fcca53a Author: Julien Duchesne <julien.duchesne@grafana.com> Date: Tue Apr 25 13:02:16 2023 -0400 Folder delete: Fix panic when params are set (grafana#146) commit 65edf1b Author: Alex Weaver <weaver.alex.d@gmail.com> Date: Tue May 2 15:02:11 2023 -0500 Add dependabot commit 3a31f6f Merge: 0252eaa 6b31ab5 Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Tue Apr 18 10:58:34 2023 +0200 Merge branch 'master' of https://github.com/flkhndlr/grafana-api-golang-client commit 0252eaa Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Tue Apr 18 10:57:39 2023 +0200 fix: change name of variable commit 6b31ab5 Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Tue Apr 18 10:44:29 2023 +0200 adding back whitespaces commit b1311f0 Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Tue Apr 18 10:41:25 2023 +0200 clear whitespaces commit 17398b1 Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Tue Apr 18 10:29:34 2023 +0200 remove whitespace commit 10b4067 Author: Julien Duchesne <julien.duchesne@grafana.com> Date: Mon Apr 10 18:58:06 2023 -0400 Folder: Add option to force delete folder (grafana#142) grafana/terraform-provider-grafana#855 commit e73fa1f Author: Julien Duchesne <julien.duchesne@grafana.com> Date: Mon Apr 10 18:57:49 2023 -0400 Add missing report fields (grafana#143) grafana/terraform-provider-grafana#862 commit 62aa037 Author: Philip Penquitt <30809710+PhilipPenquitt@users.noreply.github.com> Date: Thu Apr 6 16:49:11 2023 +0200 Trigger Build commit 2cb0ad5 Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Thu Apr 6 15:01:20 2023 +0200 adding alert_rule fetch function (grafana#1) Co-authored-by: fkhe <Falk.Haendler@t-systems.com> commit c27c52e Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Thu Apr 6 14:59:04 2023 +0200 correcting testcases commit 4732c3e Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Thu Apr 6 14:49:25 2023 +0200 correcting testcases, add documentation commit 1921ba9 Author: flkhndlr <50197097+flkhndlr@users.noreply.github.com> Date: Thu Apr 6 13:23:20 2023 +0200 adding alert_rule fetch function commit 64ddabb Author: phpe <30809710+PhilipPenquitt@users.noreply.github.com> Date: Thu Apr 6 16:46:06 2023 +0200 Trigger Build commit e009637 Author: Philip Penquitt <30809710+PhilipPenquitt@users.noreply.github.com> Date: Thu Apr 6 14:37:21 2023 +0200 fix: formating fixed
|
Can this PR be merged @julienduchesne ? I would like to use it as well 😊 |
maikelvl
pushed a commit
to maikelvl/grafana-api-golang-client
that referenced
this pull request
Nov 27, 2023
|
Is there anyone at grafana who can take a look here? |
|
This client is being deprecated soon. This is implemented in the client generated from openapi: https://github.com/grafana/grafana-openapi-client-go/blob/main/client/provisioning/provisioning_client.go#L58. I can merge this PR with a caveat: I'm not going to test it |
julienduchesne
approved these changes
Jan 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the feature to get all alert rules.
Uses the standard API.( see here https://grafana.com/docs/grafana/latest/developers/http_api/alerting_provisioning/#span-idroute-get-alert-rulesspan-get-all-the-alert-rules-_routegetalertrules)