Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: support native histograms along classic histograms in panels #1136

Closed
wants to merge 6 commits into from

Conversation

krajorama
Copy link
Contributor

@krajorama krajorama commented Jan 31, 2024

Related to grafana/mimir#7154

This branch will have force pushes.

Native histograms are
https://grafana.com/docs/mimir/latest/send/native-histograms/

This branch will have force pushes.

Native histograms are
https://grafana.com/docs/mimir/latest/send/native-histograms/

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama force-pushed the krajo/native-histogram-mixin-simple branch 2 times, most recently from b90d33e to 56bc610 Compare January 31, 2024 12:16
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama force-pushed the krajo/native-histogram-mixin-simple branch from 56bc610 to 656601b Compare January 31, 2024 12:19
…fill

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
text: 'show',
value: '1',
},
description: 'When setting this option to 1, panels will query and show deprecated low precision histogram metrics.',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'When setting this option to 1, panels will query and show deprecated low precision histogram metrics.',
description: 'When setting this option to show, panels will query and show deprecated low precision histogram metrics.',

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama
Copy link
Contributor Author

We've analyzed the different options and this was one of the worst in terms of complexity and possibility to automate to conversion for other applications/customers. Closing as failed.

@krajorama krajorama closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant