Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: unhide compactor GRPC config #12587

Merged
merged 2 commits into from
Apr 19, 2024
Merged

docs: unhide compactor GRPC config #12587

merged 2 commits into from
Apr 19, 2024

Conversation

slim-bean
Copy link
Collaborator

What this PR does / why we need it:

Was discovered by a nice community member that they had errors in their logs:

ts=2024-04-11T14:01:16.501014486Z caller=spanlogger.go:109 user=fake level=error msg="failed loading deletes for user" err="rpc error: code = Unavailable desc = connection error: desc = \"error reading server preface: EOF\""

They are using TLS between Loki components and found that they were missing getting the TLS setting correct for the compactor client used by query time filtering of delete requests (which are stored in the compactor), and also discovered that we were not exposing these configs in the docs.

This PR removes the hidden tag such that these will now show up in the docs.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean requested a review from a team as a code owner April 11, 2024 23:38
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 19, 2024
@slim-bean slim-bean merged commit 4c563f7 into main Apr 19, 2024
18 checks passed
@slim-bean slim-bean deleted the unhide-compactor-config branch April 19, 2024 12:24
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

grafanabot pushed a commit that referenced this pull request Apr 19, 2024
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Co-authored-by: DylanGuedes <djmgguedes@gmail.com>
(cherry picked from commit 4c563f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x product-approved size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants