Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Loki monitoring docs to new meta monitoring helm #13176

Merged
merged 21 commits into from
Jun 12, 2024
Merged

feat: Update Loki monitoring docs to new meta monitoring helm #13176

merged 21 commits into from
Jun 12, 2024

Conversation

Jayclifford345
Copy link
Contributor

Updated the Loki monitoring documentation to use the new meta-monitoring repo.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345 Jayclifford345 requested a review from a team as a code owner June 7, 2024 14:46
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jun 7, 2024
JStickler
JStickler reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team]

docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md Outdated Show resolved Hide resolved
Jayclifford345 and others added 9 commits June 11, 2024 14:36
@Jayclifford345 @JStickler
Update docs/sources/setup/install/helm/monitor-and-alert/with-grafana…
1865bcd 
…-cloud.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345 @JStickler
Update docs/sources/setup/install/helm/monitor-and-alert/with-grafana…
0d94877 
…-cloud.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345 @JStickler
Update docs/sources/setup/install/helm/monitor-and-alert/with-grafana…
2e9e379 
…-cloud.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345 @JStickler
Update docs/sources/setup/install/helm/monitor-and-alert/with-grafana…
675cf6c 
…-cloud.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345 @JStickler
Update docs/sources/setup/install/helm/monitor-and-alert/with-local-m…
b889859 
…onitoring.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345 @JStickler
Update docs/sources/setup/install/helm/monitor-and-alert/with-local-m…
f30f4a1 
…onitoring.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345 @JStickler
Update docs/sources/setup/install/helm/monitor-and-alert/with-local-m…
b09c737 
…onitoring.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345 @JStickler
Update docs/sources/setup/install/helm/monitor-and-alert/with-local-m…
436d0b3 
…onitoring.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345
Updated Cloud desciption and fixed wording in MinIO section
c6e5a4a
@Jayclifford345
Copy link
Contributor Author

Hi @JStickler, good catches that should be both of those sections updated and thank you for making the direct changes to the other parts. All accepted!

JStickler
JStickler reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Round two.

docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md Outdated Show resolved Hide resolved
Jayclifford345 and others added 3 commits June 12, 2024 09:46
@Jayclifford345 @JStickler
Apply suggestions from code review
2e21355 
Committing Suggestions made by Julie

Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345
Added definition for LGTM
e68cc39
@Jayclifford345
Merge branch 'main' into update-monitoring-docs
7d575a6
JStickler
JStickler reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner. I think we can probably get this merged today.

docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md Outdated Show resolved Hide resolved
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

Jayclifford345 and others added 2 commits June 12, 2024 15:26
@Jayclifford345 @JStickler
Apply suggestions from code review
f26e21c 
Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345 @JStickler
Apply suggestions from code review
702d877 
Co-authored-by: J Stickler <julie.stickler@grafana.com>
JStickler
JStickler approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler JStickler merged commit b4d44f8 into main Jun 12, 2024
60 checks passed
@JStickler JStickler deleted the update-monitoring-docs branch June 12, 2024 14:49
grafanabot pushed a commit that referenced this pull request Jun 12, 2024
@Jayclifford345 @grafana-delivery-bot
feat: Update Loki monitoring docs to new meta monitoring helm (#13176)
533d21d 
Co-authored-by: J Stickler <julie.stickler@grafana.com>
(cherry picked from commit b4d44f8)
@grafanabot grafanabot mentioned this pull request Jun 12, 2024
Merged
7 tasks
This was referenced Jun 17, 2024
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
backport release-3.0.x size/XL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jayclifford345 @grafanabot @JStickler