Copy cortex/pkg/querier/astmapper package dependency into Loki
#4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use _ in argument of method `pkg/querier/astmapper/subtree_folder.go` since it is not being used - Remove unnecessary cast from `subtree_folder.go`
trevorwhitney
approved these changes
Dec 21, 2021
| "github.com/go-kit/log/level" | ||
| "github.com/prometheus/prometheus/promql/parser" | ||
|
|
||
| util_log "github.com/cortexproject/cortex/pkg/util/log" |
There was a problem hiding this comment.
should this still be pointing to cortex?
There was a problem hiding this comment.
yes, until this PR gets merged.
Hmm that's a good question. There's already an open PR that get rid of Cortex util/util_logs, but since it is quite big and I'm expecting that it will take some time to get merged, I decided to send this one for review as it might be easier to review/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As a part of removing Loki dependency on cortex packages, we decided to copy the
querier/astmapperpackage from cortex to Loki itself.I decided to only fork this package and not whole querier because the other subpackages require code changes and the gigantique diff will make reviews a hard task. For this one I just had to copy stuff and replace
cortex/astmapperwith the new counterpart.Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.