Run OOO compaction after restart if there is OOO data from WBL #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
codesome
force-pushed
the
codesome/diskfilling
branch
from
6ef8ddd
to
e79f1c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was some OOO data on disk (in WBL or mmap chunks) that got replayed while OOO being disabled during a restart, we were not compacting that data. Hence never cleaning up the chunks_head directory of old files because those OOO mmap chunks share the chunks_head. This caused the disk to fill up after disabling OOO.
This PR fixes it by setting
db.oooWasEnabledto true if some OOO data was replayed.db.oooWasEnabledis a way to signal that compaction needs to run on OOO data.