Update to upstream 64a9abb8be (LabelValuesFor signature change)
#651
Conversation
Give more clues when troubleshooting. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
It's quite common during the compaction cycle to hold series IDs for series that aren't in the TSDB head anymore. We shouldn't fail if that happens, as the caller has no way to figure out which one of the IDs doesn't exist. Fixes prometheus/prometheus#14278 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: parnavh <parnav100sach@gmail.com>
* docs: clarify default Docker command line parameters Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl> * docs: move Docker command line parameters section and refer to Dockerfile Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl> * Add link to Dockerfile in documentation Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl> --------- Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl> Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
* chore: use HumanizeDuration from prometheus/common Signed-off-by: Sergey <freak12techno@gmail.com> * chore: fixed linting Signed-off-by: Sergey <freak12techno@gmail.com> * chore: review fixes --------- Signed-off-by: Sergey <freak12techno@gmail.com>
headIndexReader.LabelNamesFor: skip not found series
[ENHANCEMENT] HTTP API: Add url to errors logged while sending response
…insensitive comparison (#14170) * Converted string to standarized form * Added golang.org/x/text in Go dependencies * Added test cases for FastRegexMatcher * Added benchmark for toNormalizedLower Signed-off-by: RA <ranveeravhad777@gmail.com>
Adjust the default GOGC value to 75. This is less of a memory savings, but has less impact on CPU use. Signed-off-by: SuperQ <superq@gmail.com>
fix: broken link on github mobile
Tune default GOGC
The only call we have to LabelValuesFor() has an index.Postings, and we expand it to pass to this method, which will iterate over the values. That's a waste of resources: we can iterate on the index.Postings directly. If there's any downstream implementation that has a slice of series, they can always do an index.ListPostings from them: doing that is cheaper than expanding an abstract index.Postings. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
|
|
|
This introduces a performance regression in So this shouldn't go into the Mimir's weekly release without that. |
| } | ||
|
|
||
| _, ok := m.values[s] | ||
| return ok | ||
| } | ||
|
|
||
| // toNormalisedLower normalise the input string using "Unicode Normalization Form D" and then convert | ||
| // it to lower case. | ||
| func toNormalisedLower(s string) string { |
There was a problem hiding this comment.
Should this be mentioned in the PR description as a fix?
There was a problem hiding this comment.
Are we doing that?
The PR will be a merge commit, and it has a list of all the commits we brought from upstream. I'm not sure what's the utility of copying that to the description.
There was a problem hiding this comment.
Normally we tend to mention changes relevant to Mimir in these sync PRs. Makes it easier for reviewers, and to know what should make it into the Mimir changelog when the time comes.
There was a problem hiding this comment.
Normally we tend to mention changes relevant to Mimir in these sync PRs.
I think that is a mistake, because it's hard to tell here which changes are relevant to Mimir and which are not.
We should mention the changes that are relevant to Mimir when we're vendoring the used modules in Mimir.
Makes it easier for reviewers, and to know what should make it into the Mimir changelog when the time comes.
Not sure why it's easier, it's double work, we still have to review the changes when vendoring to Mimir.
colega
force-pushed
the
prometheus-main-64a9abb8be
branch
from
6c55dbd
to
6af02ae
Compare
Updates to grafana/mimir-prometheus#651 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
* Update mimir-prometheus to 26c8bac Updates to grafana/mimir-prometheus#651 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
This brings the changes from upstream up to
64a9abb8bewhich includes changes toLabelValuesFormethod: prometheus/prometheus#14280This intentionally doesn't update to latest main, which will have more changes because of the compactor interface refactor: prometheus/prometheus#14143