[r311] [BUGFIX] TSDB: Don't read in-order chunks from before head MinTime #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Oct 9, 2024
Because we are reimplementing the `IndexReader` to fetch in-order and out-of-order chunks together, we must reproduce the behaviour of `Head.indexRange()`, which floors the minimum time queried at `head.MinTime()`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> (cherry picked from commit 91de19fbeffe19429f10c501a2f4364ae01711ea)
bboreham
force-pushed
the
dimitar/weekly-r311-with-ino-mint-fix
branch
from
ccffc9f
to
2b698e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we are reimplementing the
IndexReaderto fetch in-order and out-of-order chunks together, we must reproduce the behaviour ofHead.indexRange(), which floors the minimum time queried athead.MinTime().Signed-off-by: Bryan Boreham bjboreham@gmail.com
(cherry picked from commit 91de19fbeffe19429f10c501a2f4364ae01711ea)