Skip to content

Commit

Permalink
Dashboards: add compactor autoscaling panels (#8777)
Browse files Browse the repository at this point in the history
Signed-off-by: Marco Pracucci <marco@pracucci.com>
  • Loading branch information
pracucci authored Jul 22, 2024
1 parent d385d0a commit 13f34cc
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
* [ENHANCEMENT] Dashboards: Add panels for monitoring ingester autoscaling when not using ingest-storage. These panels are disabled by default, but can be enabled using the `autoscaling.ingester.enabled: true` config option. #8484
* [ENHANCEMENT] Dashboards: add panels to show writes to experimental ingest storage backend in the "Mimir / Ruler" dashboard, when `_config.show_ingest_storage_panels` is enabled. #8732
* [ENHANCEMENT] Dashboards: show all series in tooltips on time series dashboard panels. #8748
* [ENHANCEMENT] Dashboards: add compactor autoscaling panels to "Mimir / Compactor" dashboard. The panels are disabled by default, but can be enabled setting `_config.autoscaling.compactor.enabled` to `true`. #8777
* [BUGFIX] Dashboards: fix "current replicas" in autoscaling panels when HPA is not active. #8566
* [BUGFIX] Alerts: do not fire `MimirRingMembersMismatch` during the migration to experimental ingest storage. #8727

Expand Down
4 changes: 4 additions & 0 deletions operations/mimir-mixin/config.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,10 @@
enabled: false,
hpa_name: $._config.autoscaling_hpa_prefix + 'ingester-zone-a',
},
compactor: {
enabled: false,
hpa_name: $._config.autoscaling_hpa_prefix + 'compactor',
},
},


Expand Down
4 changes: 4 additions & 0 deletions operations/mimir-mixin/dashboards/compactor.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -360,5 +360,9 @@ local fixTargetsForTransformations(panel, refIds) = panel {
.addRows($.getObjectStoreRows('Object Store', 'compactor'))
.addRow(
$.kvStoreRow('Key-value store for compactors ring', 'compactor', '.+')
)
.addRowIf(
$._config.autoscaling.compactor.enabled,
$.cpuBasedAutoScalingRow('Compactor'),
),
}
13 changes: 13 additions & 0 deletions operations/mimir-mixin/dashboards/dashboard-utils.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,19 @@ local utils = import 'mixin-utils/utils.libsonnet';
|||
),

cpuBasedAutoScalingRow(componentTitle)::
local componentName = std.strReplace(std.asciiLower(componentTitle), '-', '_');
super.row('%s – autoscaling' % [componentTitle])
.addPanel(
$.autoScalingActualReplicas(componentName)
)
.addPanel(
$.autoScalingDesiredReplicasByAverageValueScalingMetricPanel(componentName, 'CPU', 'cpu')
)
.addPanel(
$.autoScalingFailuresPanel(componentName)
),

cpuAndMemoryBasedAutoScalingRow(componentTitle)::
local componentName = std.strReplace(std.asciiLower(componentTitle), '-', '_');
super.row('%s – autoscaling' % [componentTitle])
Expand Down

0 comments on commit 13f34cc

Please sign in to comment.