-
Notifications
You must be signed in to change notification settings - Fork 524
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
store-gateway: add timeout to query gate wait (#7777)
* store-gateway: add timeout to query gate wait This PR adds a timeout to query gate waiting. The store-gateway returns an empty response. The querier treats the empty response as if the blocks weren't discovered by the store-gateway and tries them again on another store-gateway. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add CHANGELOG.md entry Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update pkg/storage/tsdb/config.go Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com> * Remote TODO Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add a spanLog to timeoutGate Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add comment on why timeoutGate is in Mimir Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update docs Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Propagate errors from store-gateway to querier when hitting concurrency limit Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Fix formatting Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update autogenerated config Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add license header Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add tests for timeoutGate Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Report timeoutGate timeouts as rejected_deadline_exceeded not rejected_other Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Properly detect custom errors in timeoutGate Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> --------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
- Loading branch information
1 parent
6d1a45c
commit 61a1c8b
Showing
11 changed files
with
287 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.