Skip to content

Commit

Permalink
Remove unused mutex from LabelNames method (#1721)
Browse files Browse the repository at this point in the history
Much like #1717, this mutex is unused.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
  • Loading branch information
56quarters authored Apr 19, 2022
1 parent 5f3abe9 commit a9ac3bd
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/querier/blocks_store_queryable.go
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,6 @@ func (q *blocksStoreQuerier) LabelNames(matchers ...*labels.Matcher) ([]string,
}

var (
resMtx sync.Mutex
resNameSets = [][]string{}
resWarnings = storage.Warnings(nil)
convertedMatchers = convertMatchersToLabelMatcher(matchers)
Expand All @@ -368,10 +367,8 @@ func (q *blocksStoreQuerier) LabelNames(matchers ...*labels.Matcher) ([]string,
return nil, err
}

resMtx.Lock()
resNameSets = append(resNameSets, nameSets...)
resWarnings = append(resWarnings, warnings...)
resMtx.Unlock()

return queriedBlocks, nil
}
Expand Down

0 comments on commit a9ac3bd

Please sign in to comment.