Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: promote autoscaling to stable #7368

Open
2 of 8 tasks
dimitarvdimitrov opened this issue Feb 12, 2024 · 6 comments
Open
2 of 8 tasks

helm: promote autoscaling to stable #7368

dimitarvdimitrov opened this issue Feb 12, 2024 · 6 comments
Assignees
Labels
helm help wanted Extra attention is needed

Comments

@dimitarvdimitrov
Copy link
Contributor

dimitarvdimitrov commented Feb 12, 2024

#7282 added autoscaling to Helm as an experimental feature. This issue is about remaining work in order to promote autoscaling to stable.

Bugs

Docs/Migration procedure

Remote URL UX

  • Support a remote different from the metamonitoring setup feat: Adding global kedaAutoscaling section #7392
  • Take the additional headers and auth from metamonitoring setup. Currently basic auth and extra headers are ignored.
  • Default to X-Scope-OrgID: metamonitoring if the config is already sending metrics to the same Mimir installation (the same way that metamonitoring computes it)
  • Add validation that is same mimir cluster is used, then metamonitoring is also enabled

Helm-jsonnet diffing

  • Add helm-jsonnet diffing so that the autoscaling configs don't get out of sync when we change one and forget to change the other. This is a matter of enabling autoscaling on select components in these two files and then making sure there are no differences between the rendered manifests. Minor differences can still be ignored via kustomiztions like this one

Make dashbaords compatible with helm-deployed KEDA objects

@beatkind
Copy link
Contributor

@dimitarvdimitrov if you want, you can assign me to both of these issues. #7368 & #7367

@dimitarvdimitrov
Copy link
Contributor Author

thanks @beatkind 🙏 I'm not sure of the level of detail in these issues, so ask away if anything isn't 100% clear

@beatkind
Copy link
Contributor

beatkind commented Feb 13, 2024

Some thoughts on

Support a remote different from the metamonitoring setup

#7282 (comment)

Basically drills down to have a global section for kedaAutoscaling:

kedaAutoscaling:
     prometheusAddress: http://... 
     customHeaders:
       {}
     pollingInterval: 10

@QuentinBisson
Copy link
Contributor

@dimitarvdimitrov is there an issue to add hpa to the components that do not have it yet like the ingester?

@dimitarvdimitrov
Copy link
Contributor Author

dimitarvdimitrov commented Apr 8, 2024

for ingesters I could only find an internal one unfortunately - grafana/mimir-squad#1410. I see that @jhalterman was last working on that. Jonathan is there a public issue for this work?

@jhalterman
Copy link
Member

The issue you cited is the only one. There's nothing public yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants