-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Prometheus and add evaluation_delay in rule group config #1474
Conversation
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
I cannot run |
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
I ran |
Oh, thanks for running it. Just realised that the change in rules config is not part of Mimir config hence wont reflect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (modulo a couple of nits)!
Given we moved the evaluation delay logic to Prometheus, it's fine to delete all such logic from Mimir.
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
@pracucci fixed the comments |
What this PR does
Upgrades Prometheus which has added evaluation_delay for the rule group. Now we don't need to manually add the delays to timestamps, hence removed it from here.
Which issue(s) this PR fixes or relates to
Fixes #1267
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]