Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review configuration topics #1485

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Review configuration topics #1485

merged 3 commits into from
Mar 15, 2022

Conversation

chri2547
Copy link
Contributor

Relates to #1478

@chri2547 chri2547 requested a review from pracucci March 15, 2022 13:35
@chri2547 chri2547 self-assigned this Mar 15, 2022
@chri2547 chri2547 added the type/docs Improvements or additions to documentation label Mar 15, 2022
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! LGTM. I just left a couple of things to double check.

Co-authored-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci merged commit 539c117 into main Mar 15, 2022
@pracucci pracucci deleted the review-configuration-topics branch March 15, 2022 14:39
pracucci added a commit that referenced this pull request Mar 21, 2022
* Review configuration topics not previously copy edited

* make doc

* Apply suggestions from code review

Co-authored-by: Marco Pracucci <marco@pracucci.com>

Co-authored-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci mentioned this pull request Mar 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants