Improve tsdb-index and tsdb-index-health. #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
aknuds1
reviewed
Mar 17, 2022
dimitarvdimitrov
approved these changes
Mar 17, 2022
| @@ -26,7 +27,10 @@ import ( | |||
| var logger = log.NewLogfmtLogger(os.Stderr) | |||
|
|
|||
| func main() { | |||
| if len(os.Args) < 2 { | |||
| verifyChunks := flag.Bool("check-chunks", false, "Verify chunks in segment files.") | |||
There was a problem hiding this comment.
nit: when i use the flag, I get an error saying Failed to read meta from block dir --check-chunks error: open --check-chunks/meta.json: no such file or directory. This is because on lines 38-42 we don't check whether the CLI arg is a directory or a block.
There was a problem hiding this comment.
Nice catch, thanks! Updated PR to use only remaining (non-CLI flag arguments) as block directories.
There was a problem hiding this comment.
A problem here is that the --help output doesn't mention the required argument:
$ ./tools/tsdb-index-health/tsdb-index-health --help
Usage of ./tools/tsdb-index-health/tsdb-index-health:
-check-chunks
Verify chunks in segment files.
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
aknuds1
approved these changes
Mar 17, 2022
aknuds1
reviewed
Mar 17, 2022
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
|
Help should be fixed now. Thanks! |
pracucci
pushed a commit
that referenced
this pull request
Mar 21, 2022
* Improve tsdb-index and tsdb-index-health. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only process remaining args as block directories. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Fix help string. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Fix help string. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds
tsdb-indextsdb-index-health(which doesn't really belong to "index health", but it's useful check. We can find a better place of it at some point.)Related to internal investigation of blocks with OOO chunks after compaction.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]