Reset frameBytesLeft when cutting a frame in streamChunkedReadResponses #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Lei <justin.lei@grafana.com>
leizor
force-pushed
the
leizor/remote-read-frame-size-reset
branch
from
0915c96
to
9a854b5
Compare
treid314
reviewed
Mar 8, 2023
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Grafana Mimir | |||
|
|
|||
| * [BUGFIX] Querier: Streaming remote read was returning 1 chunk per frame after the first frame of a series. #4423 | |||
There was a problem hiding this comment.
This should be sorted with the other [BUGFIX] tags at the bottom of the changelog file. Can you clarify the comment a bit, something like "Streaming read will return multiple chunks per frame after the first frame."?
There was a problem hiding this comment.
Oop, didn't notice they were sorted--fixed!
Signed-off-by: Justin Lei <justin.lei@grafana.com>
Co-authored-by: Tyler Reid <tyler.reid@grafana.com>
Co-authored-by: Tyler Reid <tyler.reid@grafana.com>
leizor
force-pushed
the
leizor/remote-read-frame-size-reset
branch
from
347e10d
to
a1247a8
Compare
osg-grafana
pushed a commit
that referenced
this pull request
Mar 9, 2023
…es (#4423) * Reset frameBytesLeft when cutting a frame in streamChunkedReadResponses * Update CHANGELOG.md * Rename frameBytesLeft -> frameBytesRemaining * Update pkg/querier/remote_read_test.go Signed-off-by: Justin Lei <justin.lei@grafana.com> Co-authored-by: Tyler Reid <tyler.reid@grafana.com>
pstibrany
added a commit
that referenced
this pull request
Mar 9, 2023
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
added a commit
that referenced
this pull request
Mar 9, 2023
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds a reset to
frameBytesLeftwhen streaming chunked read responses. Before this change,streamChunkedReadResponseswould start writing one chunk per frame after the initial frame.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]