Allow reading secrets from Vault to configure TLS #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Mar 10, 2023
pkg/mimir/mimir.go
Outdated
| @@ -98,6 +99,7 @@ type Config struct { | |||
| Target flagext.StringSliceCSV `yaml:"target"` | |||
| MultitenancyEnabled bool `yaml:"multitenancy_enabled"` | |||
| NoAuthTenant string `yaml:"no_auth_tenant" category:"advanced"` | |||
| VaultEnabled bool `yaml:"vault_enabled" category:"experimental"` | |||
There was a problem hiding this comment.
Can we move this inside the vault config data structure? We typically have a enabled config option inside the data struct config you want to enable.
fayzal-g
force-pushed
the
vault-client-mimir
branch
2 times, most recently
from
db91c3c
to
2157f23
Compare
pstibrany
reviewed
Mar 13, 2023
pstibrany
reviewed
Mar 14, 2023
fayzal-g
force-pushed
the
vault-client-mimir
branch
from
e349ca4
to
cb421c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
If the
VaultEnabledflag is set, creates a Vault client and reads secrets from the Vault to configure TLS for the mimir components listed here. Currently the only supported auth method is via an auth token.dskitwas updated to accept aSecretReaderinterface when configuring TLS. These are all the flags where TLS paths can currently be configured (*.tls-cert-path,*.tls-key-path,*.tls-ca-path):-distributor.ha-tracker.etcd.tls-cert-path-distributor.ring.etcd.tls-cert-path-distributor.forwarding.grpc-client.tls-cert-path-querier.store-gateway-client.tls-cert-path-ingester.client.tls-cert-path-ingester.ring.etcd.tls-cert-path-querier.frontend-client.tls-cert-path-query-frontend.grpc-client-config.tls-cert-path-query-frontend.results-cache.redis.tls-cert-path-blocks-storage.bucket-store.index-cache.redis.tls-cert-path-blocks-storage.bucket-store.chunks-cache.redis.tls-cert-path-blocks-storage.bucket-store.metadata-cache.redis.tls-cert-path-compactor.ring.etcd.tls-cert-path-store-gateway.sharding-ring.etcd.tls-cert-path-ruler.client.tls-cert-path-ruler.alertmanager-client.tls-cert-path-ruler.ring.etcd.tls-cert-path-ruler.query-frontend.grpc-client-config.tls-cert-path-alertmanager.sharding-ring.etcd.tls-cert-path-alertmanager.alertmanager-client.tls-cert-path-memberlist.tls-cert-path-query-scheduler.grpc-client-config.tls-cert-path-query-scheduler.ring.etcd.tls-cert-path-overrides-exporter.ring.etcd.tls-cert-pathChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]