Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make __meta_tenant_id available in metric_relabel_configs #4725
Make __meta_tenant_id available in metric_relabel_configs #4725
Changes from 5 commits
67a1602
a467096
ca06f5b
bec9bef
80dd2d3
3275998
6259036
fb42dda
c564be2
2cc5c4d
c0ab383
45ad0b3
955f1a9
01d07a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should make it slightly more performant. Since we want to overwrite
ts.Labels
anyway then we can pass it:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But
ts.Labels
is[]LabelAdapter
andlb.Labels()
wants LabelsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about this too much. New
stringlabels
version of labels code that we will use soon doesn't even take this parameter anymore.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it's not "new
stringlabels
version" that doesn't have this method withlabels.Labels
parameter anymore, but also latest Prometheus main (after merging prometheus/prometheus#12173) which will be in Mimir after #4759 gets merged.