Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes for v2.8 #4740

Merged
merged 19 commits into from
May 3, 2023
Merged

Release Notes for v2.8 #4740

merged 19 commits into from
May 3, 2023

Conversation

lamida
Copy link
Contributor

@lamida lamida commented Apr 17, 2023

Signed-off-by: Jon Kartago Lamida <me@lamida.net>
@lamida lamida mentioned this pull request Apr 17, 2023
30 tasks
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
@@ -13,10 +13,42 @@ The highlights that follow include the top features, enhancements, and bugfixes

## Features and enhancements

### Alertmanager improvements
- **Changed default value of block storage retention period** The new default value for `-blocks-storage.tsdb.retention-period` is `13h`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was it before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put the previous value.

Comment on lines 44 to 54
- Querier: Streaming remote read will now continue to return multiple chunks per frame after the first frame. [PR 4423](https://github.com/grafana/mimir/pull/4423)
- Store-gateway: the values for stage="processed" for the metrics cortex_bucket_store_series_data_touched and cortex_bucket_store_series_data_size_touched_bytes when using fine-grained chunks caching is now reporting the correct values of chunks held in memory. [PR 4449](https://github.com/grafana/mimir/pull/4449)
- Compactor: fixed reporting a compaction error when compactor is correctly shut down while populating blocks. [PR 4580](https://github.com/grafana/mimir/pull/4580)
- OTLP: Do not drop exemplars of the OTLP Monotonic Sum metric. [4063](https://github.com/grafana/mimir/pull/4063)
- Packaging: flag /etc/default/mimir and /etc/sysconfig/mimir as config to prevent overwrite. [PR 4587](https://github.com/grafana/mimir/pull/4587)
- Query-frontend: don't retry queries which error inside PromQL. [PR 4643](https://github.com/grafana/mimir/pull/4643)
- Store-gateway & query-frontend: report more consistent statistics for fetched index bytes. [PR 4671](https://github.com/grafana/mimir/pull/4671)
- Native histograms: fix how IsFloatHistogram determines if mimirpb.Histogram is a float histogram. [PR 4706](https://github.com/grafana/mimir/pull/4706)
- Query-frontend: fix query sharding for native histograms. [PR 4666](https://github.com/grafana/mimir/pull/4666)
- Ring status page: fixed the owned tokens percentage value displayed. [PR 4730](https://github.com/grafana/mimir/pull/4730)
- Querier: fixed chunkIterator may return values after Seek beyond end of chunk. [PR 4450](https://github.com/grafana/mimir/pull/4450)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we including all bug fixes here now? I think we should refer people to check the changelog, and only highlight most important bugfixes here.

Copy link
Contributor Author

@lamida lamida Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove small bugfixes just leave out the important bugfixes in this section.

docs/sources/mimir/release-notes/v2.8.md Outdated Show resolved Hide resolved
lamida and others added 4 commits April 17, 2023 16:45
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
@lamida lamida marked this pull request as ready for review April 17, 2023 09:51
@lamida lamida requested review from a team as code owners April 17, 2023 09:51
@lamida
Copy link
Contributor Author

lamida commented Apr 17, 2023

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!


## Features and enhancements

- **Changed default value of block storage retention period** The default value for `-blocks-storage.tsdb.retention-period` was `24h` and now is `13h`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me why this is a feature / enhancement - why would a user care about this? (eg. it reduces disk space requirements for ingesters)

Copy link
Contributor Author

@lamida lamida Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second look, you're right. This is just a simple change that we don't need to put here. However, maybe it is better to put in important changes section, because maybe there are some users that rely onto this default value.

## Features and enhancements

- **Changed default value of block storage retention period** The default value for `-blocks-storage.tsdb.retention-period` was `24h` and now is `13h`.
- **Query-frontend cached results now contain timestamp** This allows Mimir to check if cached results are still valid based on current TTL configured for tenant. Results cached by previous Mimir version are used until they expire from cache, which can take up to 7 days. If you need to use per-tenant TTL sooner, please flush results cache manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one of the top four most important features in this release? Seems like an important change that improves correctness, but I wonder if there are more important changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look again into the changelog. Those three are things that caught my eye. Please suggest if you have some points to place there.

docs/sources/mimir/release-notes/v2.8.md Outdated Show resolved Hide resolved
docs/sources/mimir/release-notes/v2.8.md Outdated Show resolved Hide resolved
docs/sources/mimir/release-notes/v2.8.md Outdated Show resolved Hide resolved
- Querier: Streaming remote read will now continue to return multiple chunks per frame after the first frame. [PR 4423](https://github.com/grafana/mimir/pull/4423)
- Query-frontend: don't retry queries which error inside PromQL. [PR 4643](https://github.com/grafana/mimir/pull/4643)
- Store-gateway & query-frontend: report more consistent statistics for fetched index bytes. [PR 4671](https://github.com/grafana/mimir/pull/4671)
- Native histograms: fix how IsFloatHistogram determines if mimirpb.Histogram is a float histogram. [PR 4706](https://github.com/grafana/mimir/pull/4706)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very low level, was this user visible in some way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, yeah, let's remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also remove this.


The following experimental options and features are now stable:

- Use protobuf internal query result payload format by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, while I'm biased, this might be worthy of being highlighted in the "features and enhancements" section 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it is a good addition :)

lamida and others added 6 commits April 21, 2023 18:05
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
…tion

Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
docs/sources/mimir/release-notes/v2.8.md Outdated Show resolved Hide resolved
docs/sources/mimir/release-notes/v2.8.md Outdated Show resolved Hide resolved
docs/sources/mimir/release-notes/v2.8.md Show resolved Hide resolved
lamida and others added 4 commits April 22, 2023 01:47
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Signed-off-by: Jon Kartago Lamida <me@lamida.net>

## Features and enhancements

- **Query-frontend and ruler now use protobuf internal query result payload format by default**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charleskorn Can you help to add more color to this? What's the benefit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add something like: "This reduces the CPU and memory utilisation of the querier, query-frontend and ruler, as well as reducing network bandwidth consumed between these components."

docs/sources/mimir/release-notes/v2.8.md Show resolved Hide resolved
docs/sources/mimir/release-notes/v2.8.md Show resolved Hide resolved
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Comment on lines 20 to 22
- **Experimental support for using Redis as cache** Mimir now can use Redis for caching results, chunks, index and metadata.
- **Experimental support for fetching secret from Vault for TLS configuration**.
- **Experimental support for querying native histograms**. This support is not finalized as the related Prometheus API is also experimental, thus the exact behavior might change in future releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be moved to the top; they're experimental, but have the most customer relevance.

Signed-off-by: Jon Kartago Lamida <me@lamida.net>
@pstibrany pstibrany merged commit ae9978b into main May 3, 2023
@pstibrany pstibrany deleted the lamida/release-note-2.8 branch May 3, 2023 07:49
grafanabot pushed a commit that referenced this pull request May 3, 2023
* Add release note md for 2.8

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Fix the title

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Add some note in the release note

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: Peter Štibraný <pstibrany@gmail.com>

* Apply PR feedback

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Small adjustment

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* More small adjustment

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Add config removal in release note

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>

* Move out non feature/enhancement changes

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Remove native histogram from bugs and add protobuf to enhancement section

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Add msi-resource into release note deprecation note

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>

* Run make doc

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Apply recent PR feedbacks

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Move experimental to the top of release note

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

---------

Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
(cherry picked from commit ae9978b)
lamida added a commit that referenced this pull request May 3, 2023
* Add release note md for 2.8

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Fix the title

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Add some note in the release note

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: Peter Štibraný <pstibrany@gmail.com>

* Apply PR feedback

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Small adjustment

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* More small adjustment

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Add config removal in release note

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>

* Move out non feature/enhancement changes

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Remove native histogram from bugs and add protobuf to enhancement section

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Add msi-resource into release note deprecation note

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>

* Update docs/sources/mimir/release-notes/v2.8.md

Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>

* Run make doc

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Apply recent PR feedbacks

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

* Move experimental to the top of release note

Signed-off-by: Jon Kartago Lamida <me@lamida.net>

---------

Signed-off-by: Jon Kartago Lamida <me@lamida.net>
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
(cherry picked from commit ae9978b)

Co-authored-by: Jon Kartago Lamida <jon.lamida@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants