Allow configuration of additional services in Rollout Progress dashboard. #5007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
approved these changes
May 16, 2023
replay
reviewed
May 16, 2023
| @@ -637,5 +637,6 @@ | |||
|
|
|||
| // Used to inject rows into dashboards at specific places that support it. | |||
| injectRows: {}, | |||
| extraServiceNames: [], | |||
There was a problem hiding this comment.
maybe this could use a comment like the above field
flxbk
force-pushed
the
felix/rollouts-dashboard-additional-services
branch
from
1e7dbdd
to
9375704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This makes it possible to configure the names of additional services to be included in the Rollout Progress dashboard.
Which issue(s) this PR fixes or relates to
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]