store-gateway: introduce more postings strategies #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to find a postings strategy which takes fewer risks but more risks than `worst-case-small-posting-lists` Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
approved these changes
May 23, 2023
pkg/storage/tsdb/config.go
Outdated
| @@ -452,6 +457,9 @@ func (cfg *BucketStoreConfig) Validate(logger log.Logger) error { | |||
| if !util.StringsContain(validSeriesSelectionStrategies, cfg.SeriesSelectionStrategyName) { | |||
| return errors.New("invalid series-selection-strategy, set one of " + strings.Join(validSeriesSelectionStrategies, ", ")) | |||
| } | |||
| if cfg.SelectionStrategies.WorstCaseSeriesPreference <= 0 { | |||
There was a problem hiding this comment.
[nit] I would enforce it only when the strategy is "worst-case".
There was a problem hiding this comment.
I did it in a924c6d
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
deleted the
dimitar/st-gw/make-worst-case-postings-strategy-configurable
branch
grafanabot
pushed a commit
that referenced
this pull request
May 23, 2023
Trying to find a postings strategy which takes fewer risks but more risks than `worst-case-small-posting-lists` Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> --------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> (cherry picked from commit 308634e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Trying to find a postings strategy which takes fewer risks but more risks than
worst-case-small-posting-listsWhich issue(s) this PR fixes or relates to
Related to #4593
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]