Querier: Refine error messages for per-tenant query limits #5059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
reviewed
May 24, 2023
aknuds1
force-pushed
the
feat/refined-limits-error-messages
branch
from
c831ede
to
73fbc91
Compare
aknuds1
force-pushed
the
feat/refined-limits-error-messages
branch
from
73fbc91
to
716a111
Compare
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
aknuds1
force-pushed
the
feat/refined-limits-error-messages
branch
from
716a111
to
e78f14c
Compare
|
@pracucci @charleskorn WDYT of my last revision? Query shards no longer mentioned. |
charleskorn
approved these changes
Jun 6, 2023
pracucci
approved these changes
Jun 6, 2023
aknuds1
force-pushed
the
feat/refined-limits-error-messages
branch
3 times, most recently
from
f10a577
to
bb77409
Compare
Refine error messages for per-tenant query limits, informing the user of the preferred strategy for not hitting the limit, in addition to how they may tweak the limit. Affected limits: * max_fetched_chunks_per_query * max_fetched_chunk_bytes_per_query * max_fetched_series_per_query Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
feat/refined-limits-error-messages
branch
from
305168f
to
d46ba11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Refine error messages for per-tenant query limits, informing the user of the preferred strategy for not hitting the limit, in addition to how they may tweak the limit. It's preferred to not increase these limits if possible, since they're designed to prevent Mimir instability. Affected limits:
I've taken inspiration from the runbooks for the limits in question on the strategy (same for all three) for not hitting them.
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]