Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce -validation.create-grace-period for exemplars too #5761

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Aug 16, 2023

What this PR does

While working on #5712, I noticed that -validation.create-grace-period was not enforced for exemplars. In this PR I propose to enforce it for exemplars too.

The way I've implemented the check in this PR follows how we enforce the "timestamp too old": if the exemplar has timestamp too far in the future, then the exemplar is silently dropped and no error is reported back to the client (but a Mimir metric is tracked). I'm open to feedback tho.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review August 16, 2023 12:34
@pracucci pracucci requested review from a team as code owners August 16, 2023 12:34
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aknuds1 aknuds1 added component/distributor enhancement New feature or request labels Aug 16, 2023
@pracucci pracucci merged commit bb6e672 into main Aug 17, 2023
32 checks passed
@pracucci pracucci deleted the enforce-exemplar-grace-period branch August 17, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants