Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of tenant federation concurrency #5874

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

56quarters
Copy link
Contributor

What this PR does

Allow the max number of per-tenant queries run concurrently to be configured when executing a multi-tenant query. This can help mitigate performance issues when running queries across more than 16 tenants at once.

Which issue(s) this PR fixes or relates to

Fixes #2715

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Allow the max number of per-tenant queries run concurrently to be
configured when executing a multi-tenant query. This can help mitigate
performance issues when running queries across more than 16 tenants at
once.

Fixes #2715

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters force-pushed the 56quarters/federation-concurrency branch from 38860f5 to 81adb3a Compare August 30, 2023 16:11
@56quarters 56quarters marked this pull request as ready for review August 30, 2023 17:32
@56quarters 56quarters requested review from a team as code owners August 30, 2023 17:32
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should mention new experimental flag in about-versioning.md file too.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters merged commit d19de08 into main Aug 31, 2023
27 checks passed
@56quarters 56quarters deleted the 56quarters/federation-concurrency branch August 31, 2023 14:18
grafanabot pushed a commit that referenced this pull request Aug 31, 2023
* Allow configuration of tenant federation concurrency

Allow the max number of per-tenant queries run concurrently to be
configured when executing a multi-tenant query. This can help mitigate
performance issues when running queries across more than 16 tenants at
once.

Fixes #2715

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>

* Note about new experimental option in docs

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>

---------

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
(cherry picked from commit d19de08)
@colega
Copy link
Contributor

colega commented Sep 1, 2023

Backport action failed because of github credentials rate limit, and it couldn't leave a comment here for same reason 🤦

I'm going to create it manually.

@colega
Copy link
Contributor

colega commented Sep 1, 2023

Created: #5900

colega added a commit that referenced this pull request Sep 1, 2023
…5874) (#5900)

* Allow configuration of tenant federation concurrency (#5874)

* Allow configuration of tenant federation concurrency

Allow the max number of per-tenant queries run concurrently to be
configured when executing a multi-tenant query. This can help mitigate
performance issues when running queries across more than 16 tenants at
once.

Fixes #2715

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>

* Note about new experimental option in docs

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>

---------

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
(cherry picked from commit d19de08)

* Move CHANGELOG.md entry to rc.1

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

---------

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: move tenant federation to query-frontend middleware
3 participants