-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mimir-prometheus to 20230907080713-7c067467a0fd #5957
Conversation
Get the fix grafana/mimir-prometheus#528 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I'd suggest adding bugfix changelog entry.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Update mimir-prometheus to 20230907080713-7c067467a0fd Get the fix grafana/mimir-prometheus#528 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit da6ebc8)
* Update mimir-prometheus to 20230907080713-7c067467a0fd Get the fix grafana/mimir-prometheus#528 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit da6ebc8) Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-5957-to-release-2.10 origin/release-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x da6ebc8d94f7b85462cfb8a03c1904b558f48668
# Push it to GitHub
git push --set-upstream origin backport-5957-to-release-2.10
git switch main
# Remove the local backport branch
git branch -D backport-5957-to-release-2.10 Then, create a pull request where the |
* Update mimir-prometheus to 20230907080713-7c067467a0fd Get the fix grafana/mimir-prometheus#528 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit da6ebc8)
* Update mimir-prometheus to 20230907080713-7c067467a0fd Get the fix grafana/mimir-prometheus#528 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit da6ebc8) Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
What this PR does
Get the fix grafana/mimir-prometheus#528
We have experienced spurious errors during head compaction on the labelvalues endpoint. This fixes the errors by
handling the case where 1) postings are read 2) head compaction clears series 3) stale postings are used to look up series.
Which issue(s) this PR fixes or relates to
Fixes N/A .
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]