Rename variables and types in query-scheduler RequestQueue #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
Sep 27, 2023
francoposa
reviewed
Sep 27, 2023
francoposa
reviewed
Sep 27, 2023
pkg/scheduler/queue/queue.go
Outdated
| availableQuerierConnections: make(chan *querierConnection), | ||
| querierOperations: make(chan querierOperation), | ||
| enqueueRequests: make(chan enqueueRequest), | ||
| getNextRequestForQuerierCalls: make(chan *getNextRequestForQuerierCall), |
There was a problem hiding this comment.
similar naming here once we settle on the type naming
francoposa
reviewed
Sep 27, 2023
francoposa
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
I'm fine to roll with this after the merge conflict is fixed.
If I were to bikeshed over one last name I'd change this setup
nextRequestForQuerierCalls chan *waitingNextRequestForQuerierCall
to just
nextRequestForQuerierCalls chan *nextRequestForQuerierCall, as the type itself doesn't necessarily indicate waiting (it could be being processed already or done), the fact that they're in a channel implies well enough that they're waiting to me.
# Conflicts: # pkg/scheduler/queue/queue.go
Merged
3 tasks
pstibrany
approved these changes
Oct 2, 2023
aknuds1
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR clarifies the names of some variables and types used in the query-scheduler's
RequestQueue.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]