Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distributor write path: put httpgrpc.Errorf() calls at the topmost level #6191

Merged
merged 24 commits into from
Oct 6, 2023
Merged

Distributor write path: put httpgrpc.Errorf() calls at the topmost level #6191

merged 24 commits into from
Oct 6, 2023

Commits on Oct 5, 2023

  1. Distributor write path: put httpgrpc.Errorf() calls at the topmost level 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d04d395 View commit details
    Browse the repository at this point in the history

  2. Implementing review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    dc32aae View commit details
    Browse the repository at this point in the history

  3. Get rid of replicasNotMatchError and tooManyClustersError 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b00249b View commit details
    Browse the repository at this point in the history

  4. Remove wrapping from req.WriteRequest() and tenant.TenantID() errors 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    944082e View commit details
    Browse the repository at this point in the history

  5. Get rid of distrbutorerror.Error interface 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    728d47c View commit details
    Browse the repository at this point in the history

  6. Get rid of push.getHTTPStatusAndMessage() 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5bcd840 View commit details
    Browse the repository at this point in the history

  7. Revert validate.CleanAndValidateMetadata signature change 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    0f784ce View commit details
    Browse the repository at this point in the history

  8. Make DistributorPushError private 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b05f212 View commit details
    Browse the repository at this point in the history

  9. Rename errors by removing the Error suffix 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d05e965 View commit details
    Browse the repository at this point in the history

  10. Handle service overloaded error correctly 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4f1bdf6 View commit details
    Browse the repository at this point in the history

  11. Fixing review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3c6ede5 View commit details
    Browse the repository at this point in the history

  12. Ensure errors.As and erros.Is work correctly 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    34c1913 View commit details
    Browse the repository at this point in the history

  13. Revert distributor_test.go 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5c2a168 View commit details
    Browse the repository at this point in the history

  14. Fix wrong status code 429 instead of 400 in case of TooManyCluster error 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    96c82a0 View commit details
    Browse the repository at this point in the history

  15. Some refactorings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    592c6d4 View commit details
    Browse the repository at this point in the history

  16. Fixing review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ac43e20 View commit details
    Browse the repository at this point in the history

  17. Adding TestToHTTPStatus 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8218c4e View commit details
    Browse the repository at this point in the history

  18. Update pkg/distributor/distributorerror/errors.go 

    Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @duricanikolic @colega
    duricanikolic and colega committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    430144d View commit details
    Browse the repository at this point in the history

  19. Re-declare ReplicasNotMatch and TooManyClusters errors 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c1d2212 View commit details
    Browse the repository at this point in the history

  20. Fixing Validation error 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    10480cd View commit details
    Browse the repository at this point in the history

  21. Get rid of most of the methods from validation/errors.go

    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    865a7f3 View commit details
    Browse the repository at this point in the history

  22. Get rid of remaining methods in validation/errors 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a179533 View commit details
    Browse the repository at this point in the history

  23. Rename all distributorerr constructors 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    55f3944 View commit details
    Browse the repository at this point in the history

  24. Fixing review findings 

    Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
    @duricanikolic
    duricanikolic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c055c8d View commit details
    Browse the repository at this point in the history