Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-2.9: golang.org/x/net libraries #6364

Merged
merged 4 commits into from
Oct 13, 2023
Merged

release-2.9: golang.org/x/net libraries #6364

merged 4 commits into from
Oct 13, 2023

Conversation

lamida
Copy link
Contributor

@lamida lamida commented Oct 13, 2023 •
edited
Loading

What this PR does

This PR updates golang.org/x/net to 0.17. These versions include fix for CVE-2023-44487.

Checklist

  • [na] Tests updated
  • [na] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@lamida
Update x/net to 0.17
27d0bcb 
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
@lamida lamida requested a review from a team as a code owner October 13, 2023 08:47
@lamida
Update changelog
718f8bf 
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
pstibrany
pstibrany reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only updates golang.org/x/net.

Please run go mod vendor to update vendored files too.

@lamida
Add vendor directory
bcbdf19 
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
@lamida lamida marked this pull request as draft October 13, 2023 12:18
@lamida
Run go mod tidy
fba8398 
Signed-off-by: Jon Kartago Lamida <me@lamida.net>
@lamida lamida changed the title release-2.9: Update grpc-go and golang.org/x/net libraries release-2.9: golang.org/x/net libraries Oct 13, 2023
pstibrany
pstibrany approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lamida lamida marked this pull request as ready for review October 13, 2023 12:47
@lamida lamida merged commit 8212234 into release-2.9 Oct 13, 2023
24 checks passed
@lamida lamida deleted the lamida/updatex-net-0.17 branch October 13, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstibrany pstibrany pstibrany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamida @pstibrany