-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
querytee: Add support to log comparatively slow queries #7346
Conversation
This adds `proxy.log-slow-query-response-threshold` which when enabled will log any queries that take longer than the configured threshold on one backend compared to the fastest backend.
5673510
to
20aeaf7
Compare
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please see comments for a typo etc :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
One other thing that would be handy to add (but could be a separate PR) is two histogram metrics of the relative and absolute latency difference between the two backends.
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Note: this changes the pre-existing `route-name` to `route_name`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo one suggestion for the tests
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
After merging in main, we need to put the changelog in unreleased.
f0b04f6
to
3b82265
Compare
This adds
proxy.log-slow-query-response-threshold
which when enabled will log any queries that take longer than the configured threshold on one backend compared to the fastest backend.CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.