Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboards: overview: use native histograms in status #7627

Merged
merged 11 commits into from
Apr 8, 2024

Conversation

krajorama
Copy link
Contributor

@krajorama krajorama commented Mar 14, 2024

What this PR does

Allow switching between basing status on classic or native version of cortex_request_duration_seconds.

Which issue(s) this PR fixes or relates to

Related to #7154

Checklist

  • N/A Tests updated.
  • TBD Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@krajorama krajorama requested a review from a team as a code owner March 14, 2024 09:05
@krajorama krajorama marked this pull request as draft March 14, 2024 09:05
Allow switching between basing status on classic or native version
of cortex_request_duration_seconds.

Related to #7154

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama force-pushed the krajo/native-overview-status branch from 0823bd6 to 58b6ee3 Compare March 20, 2024 09:03
@krajorama krajorama marked this pull request as ready for review March 20, 2024 09:04
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Add in the dashboard so it's always last.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama added a commit that referenced this pull request Mar 21, 2024
Allow using  cortex_request_duration_seconds native histogram in
overview dashboard everywhere.
Followup to #7627

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
instead of separate but equal readRequestPerSecondMetric and
writeRequestPerSecondMetric

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama added a commit that referenced this pull request Apr 5, 2024
Allow using  cortex_request_duration_seconds native histogram in
overview dashboard everywhere.
Followup to #7627

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Copy link
Contributor

@zenador zenador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krajorama krajorama merged commit f4048a5 into main Apr 8, 2024
31 checks passed
@krajorama krajorama deleted the krajo/native-overview-status branch April 8, 2024 06:32
krajorama added a commit that referenced this pull request Jun 24, 2024
…nds (#7674)

* dashboards: overview: use native histograms in status

Allow switching between basing status on classic or native version
of cortex_request_duration_seconds.

Related to #7154
Followup to #7627

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants