Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimirtool: fix panic in loadgen command #7629

Merged
merged 1 commit into from
Mar 15, 2024
Merged

mimirtool: fix panic in loadgen command #7629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,15 @@
* [BUGFIX] Ingester: Prevent timely compaction of empty blocks. #7624

### Mixin

* [ENHANCEMENT] Alerts: allow configuring alerts range interval via `_config.base_alerts_range_interval_minutes`. #7591

### Jsonnet

### Mimirtool

* [BUGFIX] Fix panic in `loadgen` subcommand. #7629

### Mimir Continuous Test

* [BUGFIX] Set `User-Agent` header for all requests sent from the testing client. #7607
Expand Down
33 changes: 16 additions & 17 deletions pkg/mimirtool/commands/loadgen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,36 +67,35 @@ type LoadgenCommand struct {
}

func (c *LoadgenCommand) Register(app *kingpin.Application, _ EnvVarNames, reg prometheus.Registerer) {
loadgenCommand := &LoadgenCommand{}
cmd := app.Command("loadgen", "Simple load generator for Grafana Mimir.").PreAction(func(k *kingpin.ParseContext) error { return c.setup(k, reg) }).Action(loadgenCommand.run)
cmd.Flag("write-url", "").
Default("").StringVar(&loadgenCommand.writeURL)
cmd := app.Command("loadgen", "Simple load generator for Grafana Mimir.").PreAction(func(k *kingpin.ParseContext) error { return c.setup(k, reg) }).Action(c.run)
cmd.Flag("write-url", "Remote write URL where to push metrics to (e.g. \"http://mimir.local/api/v1/push\")").
Default("").StringVar(&c.writeURL)
cmd.Flag("series-name", "name of the metric that will be generated").
Default("node_cpu_seconds_total").StringVar(&loadgenCommand.metricName)
Default("node_cpu_seconds_total").StringVar(&c.metricName)
cmd.Flag("active-series", "number of active series to send").
Default("1000").IntVar(&loadgenCommand.activeSeries)
Default("1000").IntVar(&c.activeSeries)
cmd.Flag("scrape-interval", "period to send metrics").
Default("15s").DurationVar(&loadgenCommand.scrapeInterval)
Default("15s").DurationVar(&c.scrapeInterval)
cmd.Flag("parallelism", "how many metrics to send simultaneously").
Default("10").IntVar(&loadgenCommand.parallelism)
Default("10").IntVar(&c.parallelism)
cmd.Flag("batch-size", "how big a batch to send").
Default("100").IntVar(&loadgenCommand.batchSize)
Default("100").IntVar(&c.batchSize)
cmd.Flag("write-timeout", "timeout for write requests").
Default("500ms").DurationVar(&loadgenCommand.writeTimeout)
Default("500ms").DurationVar(&c.writeTimeout)

cmd.Flag("query-url", "").
Default("").StringVar(&loadgenCommand.queryURL)
cmd.Flag("query-url", "API URL to query from (e.g. \"http://mimir.local/api/v1\")").
Default("").StringVar(&c.queryURL)
cmd.Flag("query", "query to run").
Default("sum(node_cpu_seconds_total)").StringVar(&loadgenCommand.query)
Default("sum(node_cpu_seconds_total)").StringVar(&c.query)
cmd.Flag("query-parallelism", "number of queries to run in parallel").
Default("10").IntVar(&loadgenCommand.queryParallelism)
Default("10").IntVar(&c.queryParallelism)
cmd.Flag("query-timeout", "").
Default("20s").DurationVar(&loadgenCommand.queryTimeout)
Default("20s").DurationVar(&c.queryTimeout)
cmd.Flag("query-duration", "length of query").
Default("1h").DurationVar(&loadgenCommand.queryDuration)
Default("1h").DurationVar(&c.queryDuration)

cmd.Flag("metrics-listen-address", "address to serve metrics on").
Default(":8080").StringVar(&loadgenCommand.metricsListenAddress)
Default("127.0.0.1:8080").StringVar(&c.metricsListenAddress)
}

func (c *LoadgenCommand) setup(_ *kingpin.ParseContext, reg prometheus.Registerer) error {
Expand Down
Loading