Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block compaction delay metric #7635

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Add block compaction delay metric #7635

merged 8 commits into from
Apr 1, 2024

Commits on Apr 1, 2024

  1. Optimize marking blocks as queried

    @jhalterman
    jhalterman committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    ccd36b7 View commit details
    Browse the repository at this point in the history

  2. Add block compaction delay summary metric

    @jhalterman
    jhalterman committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    05f4aa2 View commit details
    Browse the repository at this point in the history

  3. Address PR comments 

    - Change summary to a histogram
- Make LastUpdated field transient
- Fetch attributes only when compactor is fetching meta
- Use LastUpdated when filtering jobs
    @jhalterman
    jhalterman committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    b0d062b View commit details
    Browse the repository at this point in the history

  4. Address PR comments 

    - remove LastUpdated from block meta
- change metric to minutes and use buckets with longer durations
- only fetch attributes for compaction job filtering and recording the new metric
    @jhalterman
    jhalterman committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    f735336 View commit details
    Browse the repository at this point in the history

  5. Update pkg/compactor/bucket_compactor.go 

    Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
    @jhalterman @pstibrany
    jhalterman and pstibrany committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    54f2576 View commit details
    Browse the repository at this point in the history

  6. Revert "Optimize marking blocks as queried" 

    This reverts commit 55ef1ddd10b5b688a002b2cfb998055c92789b08.
    @jhalterman
    jhalterman committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    95e2ff8 View commit details
    Browse the repository at this point in the history

  7. Address PR comments

    @jhalterman
    jhalterman committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    8e67121 View commit details
    Browse the repository at this point in the history

  8. Update changelog

    @jhalterman
    jhalterman committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    cabea8d View commit details
    Browse the repository at this point in the history