-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix out of order exemplar error for native histograms #7640
Conversation
Port of prometheus/prometheus#13021 When receiving multiple exemplars for a native histogram in mimir via remote write, only report an error if all are older than the latest exemplar as this could be a partial update. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
@@ -88,6 +88,13 @@ func (req *WriteRequest) AddHistogramSeries(lbls [][]LabelAdapter, histograms [] | |||
return req | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It's a simple method but could you add a doc comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
For the record: I did test doing the sort in the distributor, however that would trigger a remarshalling of the remote write request and that's probably more costly than doing the sort in place. |
* Fix out of order exemplar error for native histograms Port of prometheus/prometheus#13021 When receiving multiple exemplars for a native histogram in mimir via remote write, sort them and only report an error if all are older than the latest exemplar as this could be a partial update. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> cherry pick from def7165
* Fix out of order exemplar error for native histograms Port of prometheus/prometheus#13021 When receiving multiple exemplars for a native histogram in mimir via remote write, sort them and only report an error if all are older than the latest exemplar as this could be a partial update. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> cherry pick from def7165
What this PR does
When receiving multiple exemplars for a native histogram in Mimir via remote write, sort them and only report an error if all are older than the latest exemplar as this could be a partial update.
Which issue(s) this PR fixes or relates to
Port of prometheus/prometheus#13021
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.