-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
continuous-test as module #7747
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6614cb5
Break out config
johannaratliff fd184d4
Convert continuousTestManager to service
johannaratliff 4f20f22
Use continuousTest as a module
johannaratliff fbea9ff
Not private
johannaratliff 5dfcfe2
WIP + broken
johannaratliff 0a75513
super advanced debugging with log statements
johannaratliff 222b5f0
WIP
johannaratliff fe999f9
Clean up reinstantiating unnecessary parts of the module
johannaratliff 4219c9d
Unnecessary since it's only used in the independent continuous-test a…
johannaratliff 8263e32
Pulling out config file abilities because it didn't exist before so i…
johannaratliff 0f582e2
continuous-test does not need to be in development docker-compose
johannaratliff 5fe76b1
make reference-help
johannaratliff 50b16c3
make reference-help
johannaratliff 654c6d5
Get rid of any config file abilities for continuous-test: unnecessary
johannaratliff 574a045
make reference-help
johannaratliff 095a137
CHANGELOG entry
johannaratliff 56b41c2
Merge branch 'main' into continuous-test-subcommand
johannaratliff 30470f3
start function redundant in an init
johannaratliff 6c43b47
Remove TODO comment
johannaratliff b4a650f
Remove config parts only applicable to main binary backward compatibi…
johannaratliff 578d527
Change to use other module approach of Manager as services.Service
johannaratliff 900c0d8
Revert "Change to use other module approach of Manager as services.Se…
johannaratliff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// SPDX-License-Identifier: AGPL-3.0-only | ||
|
||
package continuoustest | ||
|
||
import ( | ||
"flag" | ||
) | ||
|
||
type Config struct { | ||
Client ClientConfig `yaml:"-"` | ||
Manager ManagerConfig `yaml:"-"` | ||
WriteReadSeriesTest WriteReadSeriesTestConfig `yaml:"-"` | ||
} | ||
|
||
func (cfg *Config) RegisterFlags(f *flag.FlagSet) { | ||
cfg.Client.RegisterFlags(f) | ||
cfg.Manager.RegisterFlags(f) | ||
cfg.WriteReadSeriesTest.RegisterFlags(f) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should add a YAML section if this is going to be a standard part of Mimir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree as it doesn't run as a default startup piece of Mimir with target=all. It's currently usable as a standalone docker image with flags passed and doesn't take a config file and I think keeping it as close to current usage as possible is the best approach. I was including config for it originally and decided that passing config via file isn't something currently anyone has asked for so to hold off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other components of Mimir that have CLI flags have a corresponding YAML configuration. That makes this particular feature inconsistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree re consistency. Adding YAML support will also expose all the continuous-test flags in reference documentation, which would be quite ugly, but now that continuous-test is part of Mimir, I think we should do it.