-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle TSDB native histogram validation errors as soft errors #7773
Conversation
922f112
to
5d825c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Code changes make sense to me. I'd prefer to have some tests for mapping of TSDB native histogram errors to correct errors from Mimir.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Added testcases for all scenarios. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-7773-to-r284 origin/r284
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 51c4088cc3b5087aabf72478dcc909d011ff64c0
# Push it to GitHub
git push --set-upstream origin backport-7773-to-r284
git switch main
# Remove the local backport branch
git branch -D backport-7773-to-r284 Then, create a pull request where the |
* Revert "Distributor: add bucket count validation to native histograms (#7736)" This reverts commit fb7dbaa. * Handle TSDB native histogram validation errors are soft errors * add all testcases Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Count towards discarded samples metrics with new reason Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit 51c4088)
…#7785) * Revert "Distributor: add bucket count validation to native histograms (#7736)" This reverts commit fb7dbaa. * Handle TSDB native histogram validation errors are soft errors * add all testcases Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Count towards discarded samples metrics with new reason Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit 51c4088)
…#7785) * Revert "Distributor: add bucket count validation to native histograms (#7736)" This reverts commit fb7dbaa. * Handle TSDB native histogram validation errors are soft errors * add all testcases Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Count towards discarded samples metrics with new reason Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit 51c4088) (cherry picked from commit 868d1b3)
* Revert "Distributor: add bucket count validation to native histograms (#7736)" This reverts commit fb7dbaa. * Handle TSDB native histogram validation errors are soft errors * add all testcases Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Count towards discarded samples metrics with new reason Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit 51c4088)
…#7785) (#7786) * Revert "Distributor: add bucket count validation to native histograms (#7736)" This reverts commit fb7dbaa. * Handle TSDB native histogram validation errors are soft errors * add all testcases Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Count towards discarded samples metrics with new reason Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit 51c4088) (cherry picked from commit 868d1b3) Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
…#7787) * Revert "Distributor: add bucket count validation to native histograms (#7736)" This reverts commit fb7dbaa. * Handle TSDB native histogram validation errors are soft errors * add all testcases Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Count towards discarded samples metrics with new reason Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit 51c4088)
What this PR does
Handle TSDB native histogram validation errors as soft errors.
Which issue(s) this PR fixes or relates to
Supersedes #7736
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.