Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store-gateway: add timeout to query gate wait #7777

Merged
merged 15 commits into from
May 3, 2024
Merged

store-gateway: add timeout to query gate wait #7777

merged 15 commits into from
May 3, 2024

Commits on May 3, 2024

  1. store-gateway: add timeout to query gate wait 

    This PR adds a timeout to query gate waiting. The store-gateway returns an empty response. The querier treats the empty response as if the blocks weren't discovered by the store-gateway and tries them again on another store-gateway.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    67026f0 View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG.md entry 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    87abd77 View commit details
    Browse the repository at this point in the history

  3. Update pkg/storage/tsdb/config.go 

    Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
    @dimitarvdimitrov @charleskorn
    dimitarvdimitrov and charleskorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    63adee8 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md 

    Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
    @dimitarvdimitrov @charleskorn
    dimitarvdimitrov and charleskorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    52d2596 View commit details
    Browse the repository at this point in the history

  5. Remote TODO 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    608b5a9 View commit details
    Browse the repository at this point in the history

  6. Add a spanLog to timeoutGate 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7a0d772 View commit details
    Browse the repository at this point in the history

  7. Add comment on why timeoutGate is in Mimir 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    573ec0d View commit details
    Browse the repository at this point in the history

  8. Update docs 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    68a0024 View commit details
    Browse the repository at this point in the history

  9. Propagate errors from store-gateway to querier when hitting concurren… 

    …cy limit

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ed7012c View commit details
    Browse the repository at this point in the history

  10. Fix formatting 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f09508c View commit details
    Browse the repository at this point in the history

  11. Update autogenerated config 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    523f26a View commit details
    Browse the repository at this point in the history

  12. Add license header 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    28b00ff View commit details
    Browse the repository at this point in the history

  13. Add tests for timeoutGate 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    375a044 View commit details
    Browse the repository at this point in the history

  14. Report timeoutGate timeouts as rejected_deadline_exceeded not rejecte… 

    …d_other

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    413a415 View commit details
    Browse the repository at this point in the history

  15. Properly detect custom errors in timeoutGate 

    Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
    @dimitarvdimitrov
    dimitarvdimitrov committed May 3, 2024
    Configuration menu
    Copy the full SHA
    df43e5f View commit details
    Browse the repository at this point in the history