Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compactor's max_unavailable work with odd number of replicas #7878

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Make compactor's max_unavailable work with odd number of replicas #7878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fb6a27
Make max_unavailable work with odd number of compactor replicas.
pstibrany Apr 11, 2024
3c1106f
CHANGELOG.md
pstibrany Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
### Jsonnet

* [CHANGE] Memcached: Change default read timeout for chunks and index caches to `750ms` from `450ms`. #7778
* [ENHANCEMENT] Compactor: add `$._config.cortex_compactor_concurrent_rollout_enabled` option (disabled by default) that makes use of rollout-operator to speed up the rollout of compactors. #7783
* [ENHANCEMENT] Compactor: add `$._config.cortex_compactor_concurrent_rollout_enabled` option (disabled by default) that makes use of rollout-operator to speed up the rollout of compactors. #7783 #7878
* [ENHANCEMENT] Shuffle-sharding: add `$._config.shuffle_sharding.ingest_storage_partitions_enabled` and `$._config.shuffle_sharding.ingester_partitions_shard_size` options, that allow configuring partitions shard size in ingest-storage mode. #7804
* [BUGFIX] Guard against missing samples in KEDA queries. #7691

Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-compactor-concurrent-rollout-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,15 +860,15 @@ apiVersion: apps/v1
kind: StatefulSet
metadata:
annotations:
rollout-max-unavailable: "8"
rollout-max-unavailable: "7"
labels:
name: compactor
rollout-group: compactor
name: compactor
namespace: default
spec:
podManagementPolicy: Parallel
replicas: 16
replicas: 15
selector:
matchLabels:
name: compactor
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-tests/test-compactor-concurrent-rollout.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ mimir {
},

compactor_statefulset+:
$.apps.v1.statefulSet.mixin.spec.withReplicas(16),
$.apps.v1.statefulSet.mixin.spec.withReplicas(15),
}
2 changes: 1 addition & 1 deletion operations/mimir/config.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
// This feature modifies the compactor StatefulSet which cannot be altered, so if it already exists it has to be deleted and re-applied again in order to be enabled.
cortex_compactor_concurrent_rollout_enabled: false,
// Maximum number of unavailable replicas during a compactor rollout when using cortex_compactor_concurrent_rollout_enabled feature.
cortex_compactor_max_unavailable: std.max($.compactor_statefulset.spec.replicas / 2, 1),
cortex_compactor_max_unavailable: std.max(std.floor($.compactor_statefulset.spec.replicas / 2), 1),

// Enable use of bucket index by querier, ruler and store-gateway.
bucket_index_enabled: true,
Expand Down
Loading