ingest-store: expose Kafka operations via traces #7967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
narqo
commented
Apr 25, 2024
| @@ -68,6 +69,7 @@ func commonKafkaClientOptions(cfg KafkaConfig, metrics *kprom.Metrics, logger lo | |||
| kgo.MetadataMaxAge(10 * time.Second), | |||
|
|
|||
| kgo.WithLogger(newKafkaLogger(logger)), | |||
| kgo.WithHooks(kotel.NewKotel(kotel.WithTracer(kotel.NewTracer())).Hooks()...), | |||
There was a problem hiding this comment.
Note that here we rely on OTel's global tracer (kotel.NewTracer falls back to it under the hood), rather than trying to pass the tracer as a dependency, like we do here for logger and metrics. I believe, this is fine and this is how tracing is used in gRPC and HTTP clients/servers.
dimitarvdimitrov
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This one improves the visibility between ingest-store and Kafka brokers by exposing the kgo's operations into traces.
Right now, all traces from the
api_v1_pushcalls stop in the distributor. With the changes here, eachPublishoperation also become visible in the traces of the write path:Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.