Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test makes use of a
sync.Pool
under the hood, which apparently does not consistently ensure that when requesting a new item, the item returned is always the one that was previously returned to the pool.To avoid this effect, it has been decided to revert to using a type fakePool, as was done previously before the #8082 change was introduced.
What this PR does
To validate that the test is no longer flaky, the following command has been executed:
Which issue(s) this PR fixes or relates to
Fixes N/A
ref: https://github.com/grafana/mimir/actions/runs/9057849698/job/24882485441?pr=8114#step:8:79