-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce global, per-tenant flags and interval to evaluation threshold to control rule evaluation concurrency #8146
Commits on Jul 25, 2024
-
Introduce global and per-tenant flags to control rule evaluation conc…
…urrency This change introduces two flags that control if rule evaluation concurrently. First, you have a flag that controls the total amount of rules that can be running concurrently at any given time per ruler replica with: `-ruler.max-global-rule-evaluation-concurrency` Then, this is paired with `-ruler.max-concurrent-rule-evaluations-per-tenant` to control the amount of rules a single tenant is allowed to have concurrently. By default, this is `4`. However, the behaviour is disabled by default because `-ruler.max-global-rule-evaluation-concurrency` is set to `0` by default. Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 948d343 - Browse repository at this point
Copy the full SHA 948d343View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac127c2 - Browse repository at this point
Copy the full SHA ac127c2View commit details -
lint: Use Uber's atomic instead of sync
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d4ad00f - Browse repository at this point
Copy the full SHA d4ad00fView commit details -
Configuration menu - View commit details
-
Copy full SHA for da3a559 - Browse repository at this point
Copy the full SHA da3a559View commit details -
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0ba2e16 - Browse repository at this point
Copy the full SHA 0ba2e16View commit details -
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f4f29d8 - Browse repository at this point
Copy the full SHA f4f29d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29b1b5f - Browse repository at this point
Copy the full SHA 29b1b5fView commit details -
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ddeb56e - Browse repository at this point
Copy the full SHA ddeb56eView commit details
Commits on Jul 26, 2024
-
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d403bef - Browse repository at this point
Copy the full SHA d403befView commit details -
Rename both configuration for the ruler instance and the per tenant o…
…verride Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for de2e543 - Browse repository at this point
Copy the full SHA de2e543View commit details -
Update
about-versioning.md
and make sure the flag is marked as expe……rimental Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 421acfa - Browse repository at this point
Copy the full SHA 421acfaView commit details -
address review comments in
rule_concurrency.go
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 004f3a1 - Browse repository at this point
Copy the full SHA 004f3a1View commit details -
Make threshold for group at risk configurable and test it
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f419dc0 - Browse repository at this point
Copy the full SHA f419dc0View commit details
Commits on Jul 27, 2024
-
move total metric increment to after we know is eligble.
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b08738d - Browse repository at this point
Copy the full SHA b08738dView commit details -
- rename the threshold flag to include the suffix percentange - adjust the variable names for the threhold accordingly - incorporate taylor's feedback on the changelog Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c4f16e7 - Browse repository at this point
Copy the full SHA c4f16e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79c5590 - Browse repository at this point
Copy the full SHA 79c5590View commit details -
add threshold control to about-versioning.md
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 43c3ede - Browse repository at this point
Copy the full SHA 43c3edeView commit details